Messages in this thread |  | | | Date | Mon, 17 Aug 2009 11:08:53 +0300 | | From | Sergey Senozhatsky <> | | Subject | Re: [PATCH 1/1] VIDEO: console, use DIV_ROUND_UP |
| |
On (08/17/09 10:00), Jiri Slaby wrote: > On 08/17/2009 10:00 AM, Sergey Senozhatsky wrote: > > So... In general, ((vc->vc_font.width + 7) >> 3) == DIV_ROUND_UP(vc->vc_font.width, 8) - 1; > > ? > Oops, silly me. Somehow I thought about DIV_ROUND_UP((vc->vc_font.width + 7) , 8). My fault. Sorry.
> #define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d)) > > DIV_ROUND_UP(vc->vc_font.width, 8) expands to: > (((vc->vc_font.width) + (8) - 1) / (8)) > which is pretty printed: > (vc->vc_font.width + 7) / 8 > and that's equivalent to: > (vc->vc_font.width + 7) >> 3 > > Correct? Right.
> > > Are you sure we really can use DIV_ROUND_UP? > > Yeah, pretty sure. > OK.[unhandled content-type:application/pgp-signature] |  |