Messages in this thread | | | Date | Tue, 18 Aug 2009 01:06:54 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled |
| |
* David Miller <davem@davemloft.net> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com> > Date: Mon, 17 Aug 2009 13:37:36 -0700 > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > Fix trace_skb_sources build when CONFIG_NET is not enabled: > > > > kernel/built-in.o: In function `probe_skb_dequeue': > > trace_skb_sources.c:(.text+0xd9152): undefined reference to `init_net' > > trace_skb_sources.c:(.text+0xd9188): undefined reference to `dev_get_by_index' > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Applied, thanks Randy.
... but these are the wrong patches, they should be removed or reverted and redone properly.
It's not just about keeping kernel/trace/* changes in the tracing tree (which we can relax on-demand given agreement), it's that these patches are also _wrong_ and we cannot relax anything about that.
Ingo
| |