lkml.org 
[lkml]   [2009]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch 1/2] selinux: ajust rules for ATTR_FORCE
Date
Stephen Smalley <sds@tycho.nsa.gov> writes:

>> E.g. mode change has implicit ATTR_CTIME change. So it meant, we should
>> check the both of FILE__SETATTR and FILE__WRITE?
>
> No, just setattr.

Ok.

>> > ATTR_FORCE is supposed to suppress permission checking altogether, and
>> > shouldn't be mixed with multiple attribute changes if some should be
>> > subject to permission checks while others should not.
>>
>> I disagree. In fact, ATTR_FORCE is just used for ATTR_KILL_S[UG]ID, and
>> notify_change() is disallowing the mixed ATTR_MODE and ATTR_KILL_*. I
>> think it should be enough.
>
> Ok, then we just need to adjust selinux_inode_setattr to understand that
> ATTR_FORCE only means to bypass checking on ATTR_MODE.

Ok, sure. I'll try it.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2009-08-17 22:13    [W:0.053 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site