Messages in this thread Patch in this message | | | From | Bartlomiej Zolnierkiewicz <> | Date | Sun, 16 Aug 2009 21:29:47 +0200 | Subject | [PATCH 02/22] Staging: rt3070: fix build warnings |
| |
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Subject: [PATCH] Staging: rt3070: fix build warnings
In file included from drivers/staging/rt3070/common/../../rt2870/common/cmm_data.c:2, from drivers/staging/rt3070/common/cmm_data.c:2: drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/cmm_data.c: In function âRTMP_FillTxBlkInfoâ: drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/cmm_data.c:1018: warning: label âFillTxBlkErrâ defined but not used
In file included from drivers/staging/rt3070/common/../../rt2870/common/eeprom.c:2, from drivers/staging/rt3070/common/eeprom.c:2: drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c: In function âset_eFuseLoadFromBin_Procâ: drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c:1041: warning: unused variable âorgfsgidâ drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c:1041: warning: unused variable âorgfsuidâ
In file included from drivers/staging/rt3070/../rt2870/rt_profile.c:2, from drivers/staging/rt3070/rt_profile.c:2: drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c: In function âRTMPReadParametersHookâ: drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c:863: warning: unused variable âorgfsgidâ drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c:863: warning: unused variable âorgfsuidâ
In file included from drivers/staging/rt3070/common/rtusb_io.c:2: drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c: In function âCMDHandlerâ: drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: âCipherAlgâ may be used uninitialized in this function drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1758: note: âCipherAlgâ was declared here drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: âKeyIdxâ may be used uninitialized in this function drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1757: note: âKeyIdxâ was declared here drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: âApIdxâ may be used uninitialized in this function drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1759: note: âApIdxâ was declared here
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/staging/rt2860/common/cmm_data.c | 5 ----- drivers/staging/rt2860/common/eeprom.c | 14 +++----------- drivers/staging/rt2860/rt_profile.c | 11 +---------- drivers/staging/rt2870/common/rtusb_io.c | 6 +++--- 4 files changed, 7 insertions(+), 29 deletions(-)
Index: b/drivers/staging/rt2860/common/cmm_data.c =================================================================== --- a/drivers/staging/rt2860/common/cmm_data.c +++ b/drivers/staging/rt2860/common/cmm_data.c @@ -1013,11 +1013,6 @@ BOOLEAN RTMP_FillTxBlkInfo( } return TRUE; - -#ifdef RT30xx -FillTxBlkErr: - return FALSE; -#endif } Index: b/drivers/staging/rt2860/common/eeprom.c =================================================================== --- a/drivers/staging/rt2860/common/eeprom.c +++ b/drivers/staging/rt2860/common/eeprom.c @@ -1038,7 +1038,7 @@ INT set_eFuseLoadFromBin_Proc( { CHAR *src; struct file *srcf; - INT retval, orgfsuid, orgfsgid; + INT retval; mm_segment_t orgfs; UCHAR *buffer; UCHAR BinFileSize=0; @@ -1078,12 +1078,7 @@ INT set_eFuseLoadFromBin_Proc( kfree(buffer); return FALSE; } - /* Don't change to uid 0, let the file be opened as the "normal" user */ -#if 0 - orgfsuid = current->fsuid; - orgfsgid = current->fsgid; - current->fsuid=current->fsgid = 0; -#endif + orgfs = get_fs(); set_fs(KERNEL_DS); @@ -1146,10 +1141,7 @@ INT set_eFuseLoadFromBin_Proc( DBGPRINT(RT_DEBUG_TRACE, ("--> Error %d closing %s\n", -retval, src)); } set_fs(orgfs); -#if 0 - current->fsuid = orgfsuid; - current->fsgid = orgfsgid; -#endif + for(j=0;j<i;j++) { DBGPRINT(RT_DEBUG_TRACE, ("%02X ",buffer[j])); Index: b/drivers/staging/rt2860/rt_profile.c =================================================================== --- a/drivers/staging/rt2860/rt_profile.c +++ b/drivers/staging/rt2860/rt_profile.c @@ -860,7 +860,7 @@ NDIS_STATUS RTMPReadParametersHook( { PUCHAR src = NULL; struct file *srcf; - INT retval, orgfsuid, orgfsgid; + INT retval; mm_segment_t orgfs; CHAR *buffer; CHAR *tmpbuf; @@ -884,15 +884,6 @@ NDIS_STATUS RTMPReadParametersHook( src = STA_PROFILE_PATH; - // Save uid and gid used for filesystem access. - // Set user and group to 0 (root) -#ifndef RT30xx - orgfsuid = current_fsuid(); - orgfsgid = current_fsgid(); - /* Hm, can't really do this nicely anymore, so rely on these files - * being set to the proper permission to read them... */ - /* current->cred->fsuid = current->cred->fsgid = 0; */ -#endif orgfs = get_fs(); set_fs(KERNEL_DS); Index: b/drivers/staging/rt2870/common/rtusb_io.c =================================================================== --- a/drivers/staging/rt2870/common/rtusb_io.c +++ b/drivers/staging/rt2870/common/rtusb_io.c @@ -1754,9 +1754,9 @@ VOID CMDHandler( case RT_CMD_SET_RX_WCID_TABLE: //General call for RTMPAddWcidAttributeEntry() { PMAC_TABLE_ENTRY pEntry; - UCHAR KeyIdx; - UCHAR CipherAlg; - UCHAR ApIdx; + UCHAR KeyIdx = 0; + UCHAR CipherAlg = 0; + UCHAR ApIdx = 0; pEntry = (PMAC_TABLE_ENTRY)(pData); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |