Messages in this thread | | | Date | Fri, 14 Aug 2009 14:45:03 -0700 | From | David VomLehn <> | Subject | Re: [PATCH 1/2] Use kfifo to buffer USB generic serial writes |
| |
On Fri, Aug 14, 2009 at 10:20:39PM +0100, Alan Cox wrote: > > + spin_lock_irqsave(&port->write_fifo_lock, flags); > > + chars = __kfifo_len(port->write_fifo); > > + spin_unlock_irqrestore(&port->write_fifo_lock, flags); > > Any reason for not using kfifo_len() ?
Nope. At one time there was a bit more code protected here and when I took it out, I missed the opportunity to squash it down. I'll incorporate this with any other changes that come in.
> Alan
| |