lkml.org 
[lkml]   [2009]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 27/28] ALSA: hda - Add missing vmaster initialization for ALC269
    At Thu, 13 Aug 2009 13:12:22 -0700,
    Greg KH wrote:
    >
    > On Thu, Aug 13, 2009 at 12:59:05PM -0700, Linus Torvalds wrote:
    > >
    > >
    > > On Thu, 13 Aug 2009, Greg KH wrote:
    > > >
    > > > From: Takashi Iwai <tiwai@suse.de>
    > > >
    > > > commit 100d5eb36ba20dc0b99a17ea2b9800c567bfc3d1 upstream.
    > > >
    > > > Without the initialization of vmaster NID, the dB information got
    > > > confused for ALC269 codec.
    > > >
    > > > Reference: Novell bnc#527361
    > > > https://bugzilla.novell.com/show_bug.cgi?id=527361
    > > >
    > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
    > > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    > > >
    > > > ---
    > > > sound/pci/hda/patch_realtek.c | 2 ++
    > > > 1 file changed, 2 insertions(+)
    > > >
    > > > --- a/sound/pci/hda/patch_realtek.c
    > > > +++ b/sound/pci/hda/patch_realtek.c
    > > > @@ -13767,6 +13767,8 @@ static int patch_alc861vd(struct hda_cod
    > > >
    > > > spec->vmaster_nid = 0x02;
    > > >
    > > > + spec->vmaster_nid = 0x02;
    > > > +
    > > > codec->patch_ops = alc_patch_ops;
    > >
    > > You seem to have already applied this one earlier ;)
    >
    > Heh, good catch, I've now removed this one from the queue.

    Well, the patch has to be applied to another place, namely in the
    function patch_alc269(), but patch seems confused because the offset
    is too big.

    As I'm off today, I'm going to check it and resend the patch for
    2.6.27 tomorrow.


    thanks,

    Takashi


    \
     
     \ /
      Last update: 2009-08-14 08:59    [W:0.025 / U:0.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site