Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 5/6] new kfifo API v0.3 - add kfifo_skip, kfifo_from_user and kfifo_to_user | Date | Fri, 14 Aug 2009 14:25:42 +0200 |
| |
On Friday 14 August 2009, Stefani Seibold wrote: > This is patch 5/6 of the new kfifo API: > kfifo_reset_out() to lockless save discard the fifo output > Add kfifo_skip() to skip a number of output bytes > Add kfifo_from_user() to copy user space data into the fifo > Add kfifo_to_user() to copy fifo data to user space > Do some code reorg
kfifo_skip is missing a comment regarding what it does, and as with the other patches, the description should line out why this is done, not what you do.
> Signed-off-by: Stefani Seibold <stefani@seibold.net>
Otherwise, Acked-by: Arnd Bergmann <arnd@arndb.de>
| |