lkml.org 
[lkml]   [2009]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP
    On 08/13/2009 07:06 PM, Wang, Shane wrote:
    > I agree with hpa, considering TXT doesnot depends on acpi sleep.
    >
    > However, for hpa's patch, set_mac_regions() is for S3 only. I am wondering whether we should enlarge the range of CONFIG_ACPI_SLEEP in set_mac_regions().
    > Certainly, for code cleanness, this patch is fine since the assignment
    >
    >
    > takes effect but tboot->mac_regions[] will never be used without S3.
    >

    OK, that makes it easier. We should just conditionalize the whole thing
    then. A lot cleaner than #ifdefing the individual assignments.

    -hpa

    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2009-08-14 04:57    [W:0.020 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site