Messages in this thread | | | Subject | Re: [PATCH] swap: send callback when swap slot is freed | From | Peter Zijlstra <> | Date | Thu, 13 Aug 2009 08:53:00 +0200 |
| |
On Thu, 2009-08-13 at 08:00 +0530, Nitin Gupta wrote: > > I don't share Peter's view that it should be using a more general > > notifier interface (but I certainly agree with his EXPORT_SYMBOL_GPL). > > Considering that the callback is made under swap_lock, we should not > have an array of callbacks to do. But what if this callback finds other > users too? I think we should leave it in its current state till it finds > more users and probably add BUG() to make sure callback is not already set. > > I will make it EXPORT_SYMBOL_GPL.
If its such a tightly coupled system, then why is compcache a module?
| |