lkml.org 
[lkml]   [2009]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.h in davinci_wdt.c
From
Date
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> On Mon, Aug 10, 2009 at 02:04:31PM -0700, Kevin Hilman wrote:
>> @@ -86,6 +88,9 @@ static void wdt_enable(void)
>> {
>> u32 tgcr;
>> u32 timer_margin;
>> + u32 wdt_freq;
>> +
>> + wdt_freq = clk_get_rate(wdt_clk);
>
> Much better - and only a minor nit which doesn't deserve a repost -
> wdt_freq should probably match the return type of clk_get_rate. IOW
> unsigned long.

Wim,

If you're OK with this, can you queue this one for 2.6.32?

Thanks,

Kevin


\
 
 \ /
  Last update: 2009-08-13 17:09    [W:0.286 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site