lkml.org 
[lkml]   [2009]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][patch 10/12] move NTP adjusted clock multiplier to struct timekeeper
    On Thu, 13 Aug 2009 13:15:06 +0200
    Linus Walleij <linus.ml.walleij@gmail.com> wrote:

    > 2009/7/29 Martin Schwidefsky <schwidefsky@de.ibm.com>:
    >
    > > Index: linux-2.6/arch/arm/plat-omap/common.c
    > > ===================================================================
    > > --- linux-2.6.orig/arch/arm/plat-omap/common.c
    > > +++ linux-2.6/arch/arm/plat-omap/common.c
    > > @@ -256,7 +256,7 @@ unsigned long long sched_clock(void)
    > > unsigned long long ret;
    > >
    > > ret = (unsigned long long)clocksource_32k.read(&clocksource_32k);
    > > - ret = (ret * clocksource_32k.mult_orig) >> clocksource_32k.shift;
    > > + ret = (ret * clocksource_32k.mult) >> clocksource_32k.shift;
    >
    > Doesn't the overall effect of your patch mean that the above can simply be
    > replaced by
    >
    > ret = cyc2ns(&clocksource_32k, ret);
    >
    > Or clocksource_cyc2ns() if that was renamed (I don't have the entire
    > picture here...)
    >
    > > return ret;
    > > }

    Yes, you can do that. More specifically it will be

    clocksource_cyc2ns(ret, clocksource_32k.mult, clocksource_32k.shift)

    after all patches are applied.

    --
    blue skies,
    Martin.

    "Reality continues to ruin my life." - Calvin.



    \
     
     \ /
      Last update: 2009-08-13 13:25    [W:0.026 / U:30.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site