lkml.org 
[lkml]   [2009]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC patch] init default dma_ops to prepare intel_iommu_init failure
From
Date
On Wed, 2009-08-12 at 11:17 -0700, Fenghua Yu wrote:
>
> > void __init pci_swiotlb_init(void)
> > {
> > - if (!iommu_detected || iommu_pass_through) {
>
> This check can not be removed. Otherwise, swiotlb_dma_ops will always override
> previous dma_ops value.
>
> I think you can change this check to something like:
> if (!dma_ops || iommu_pass_through) {
> With this change, checking iommu_detected is unnecesary because checking dma_ops
> covers it.

Hm, that iommu_pass_through should go away anyway. See commit 19943b0e3.

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation



\
 
 \ /
  Last update: 2009-08-12 20:27    [W:0.068 / U:5.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site