Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] fix memory leak in virtio_net | Date | Wed, 12 Aug 2009 22:11:53 +0930 |
| |
On Tue, 11 Aug 2009 09:22:58 pm Avi Kivity wrote: > (copying Rusty, the virtio maintainer) > > On 08/10/2009 11:05 PM, Shirley Ma wrote: > > Whild reading virtio code, I found some memory leak in removing > > virtio_net. > > > > In virtnet_remove, only skb has been freed not the pages in skb > > frags. Here is the patch to fix this, please review it.
Nope, kfree_skb() frees the frags.
It needs to, otherwise we leak on every received packet!
Cheers, Rusty.
| |