lkml.org 
[lkml]   [2009]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] fix memory leak in virtio_net
    Date
    On Tue, 11 Aug 2009 09:22:58 pm Avi Kivity wrote:
    > (copying Rusty, the virtio maintainer)
    >
    > On 08/10/2009 11:05 PM, Shirley Ma wrote:
    > > Whild reading virtio code, I found some memory leak in removing
    > > virtio_net.
    > >
    > > In virtnet_remove, only skb has been freed not the pages in skb
    > > frags. Here is the patch to fix this, please review it.

    Nope, kfree_skb() frees the frags.

    It needs to, otherwise we leak on every received packet!

    Cheers,
    Rusty.


    \
     
     \ /
      Last update: 2009-08-12 14:45    [W:2.260 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site