Messages in this thread | | | Date | Wed, 12 Aug 2009 12:08:51 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/3] perf tools: Factorize high level dso helpers |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Wed, Aug 12, 2009 at 11:26:00AM +0200, Frederic Weisbecker wrote: > > Factorize multiple definitions of high level dso helpers into the > > symbol source file. > > > > The side effect is a general export of the verbose and eprintf > > debugging helpers into a new file dedicated to debugging purposes. > > > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Mike Galbraith <efault@gmx.de> > > Cc: Brice Goglin <Brice.Goglin@inria.fr> > > --- > > tools/perf/Makefile | 1 + > > tools/perf/builtin-annotate.c | 96 ---------------------------------------- > > tools/perf/builtin-record.c | 1 - > > tools/perf/builtin-report.c | 97 ----------------------------------------- > > tools/perf/builtin-stat.c | 1 - > > tools/perf/builtin-top.c | 4 -- > > tools/perf/builtin.h | 1 + > > tools/perf/perf.h | 1 + > > tools/perf/util/symbol.c | 97 +++++++++++++++++++++++++++++++++++++++++ > > tools/perf/util/symbol.h | 11 +++++ > > 10 files changed, 111 insertions(+), 199 deletions(-) > > > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile > > index de7beac..2aee21b 100644 > > --- a/tools/perf/Makefile > > +++ b/tools/perf/Makefile > > @@ -339,6 +339,7 @@ LIB_OBJS += util/pager.o > > LIB_OBJS += util/header.o > > LIB_OBJS += util/callchain.o > > LIB_OBJS += util/values.o > > +LIB_OBJS += util/debug.o > > > Damn, did I forgot to git-add util/debug.c ? > > How could I fix this? Another pull request?
yeah. I've zapped those commits from perfcounters/core.
Ingo
| |