lkml.org 
[lkml]   [2009]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] applicom: Prevent unsigned wrap in ac_interrupt()
From
>> unsigned i wraps if this occurs in the first iteration.
>
> Could you elaborate? I don't quite understand the point.

`i' is unsigned. The last test in the loop is:

if(readb(apbs[i].RamIO + RAM_IT_TO_PC)) {
/* There's another int waiting on this card */
spin_unlock(&apbs[i].mutex);
i--;
} else {
spin_unlock(&apbs[i].mutex);
}

In the first iteration `i' is 0, so if this condition evaluates to true
then `i' becomes 0xffffffff (since it's unsigned), the for loop test
fails and the i++ never occurs.

>> Or do we know this can't happen?
>
> You mean the i--? It's followed by i++ in the for loop 3rd expression. Or?

No, I meant: do we know the test can't evaluate to true in the first iteration?

Thanks,

Roel


\
 
 \ /
  Last update: 2009-08-11 14:27    [W:0.047 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site