Messages in this thread | | | From | Jack Morgenstein <> | Subject | Re: [ofa-general] Re: [PATCH 10/14] infiniband: use printk_once | Date | Tue, 11 Aug 2009 10:17:21 +0300 |
| |
On Monday 10 August 2009 20:42, Roland Dreier wrote: > > > I'm a bit nervous about this one. > > printk_once will print once ONLY if CONFIG_PRINTK is set in include/linux/autoconf.h > > (i.e., when the kernel is configured). Otherwise, it gets defined to printk -- > > and it will always print in this case. > > (see 2.6.30.xx kernel include file "include/linux/kernel.h", lines 235, 249, and 272). > > Umm... if CONFIG_PRINTK is turned off nothing prints, right? Jiri Slaby pointed that out to me -- i.e., that printk itself is defined to do nothing but return 0 if CONFIG_PRINTK is not defined. (I missed that when looking at file kernel.h).
I thought no answer was needed (sorry about that) -- Jiri was so obviously correct.
I've got no problem with the patch.
-Jack
| |