Messages in this thread |  | | | Date | Tue, 11 Aug 2009 14:52:58 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH] md: avoid use of broken kzalloc mempool |
| |
On Tue, 4 Aug 2009 08:03:52 +1000 (EST) "NeilBrown" <neilb@suse.de> wrote:
> On Tue, August 4, 2009 6:54 am, Sage Weil wrote: > > The kzalloc mempool does not re-zero items that have been used and then > > returned to the pool. Manually zero the allocated multipath_bh instead. > > > > CC: linux-raid@vger.kernel.org > > CC: Neil Brown <neilb@suse.de> > > CC: <stable@kernel.org>
Sage, why did you cc stable@kernel.org? The patch fixes some bug? What is it? Why is the fix sufficiently important to warrant backporting?
> Acked-by: NeilBrown <neilb@suse.de> >
Thanks, I'll merge it once the above is understood.
> > In fact, you don't even need the memset. After allocation > no assumptions are made about the content of the structure. > Every field is immediately initialised except retry_list, which > is never accessed until after the object is placed on a list.h list. > > So this code never needed kzalloc_pool.
Well, that's a bit of a functional change so let us (ie: you ;)) do that separately?
|  |