lkml.org 
[lkml]   [2009]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 4/4] ipc: sem optimise simple operations
    [npiggin@suse.de - Tue, Aug 11, 2009 at 09:09:06PM +1000]
    ...
    | +static void update_queue_simple(struct sem_array *sma, ushort semnum)
    | +{
    | + if (unlikely(sma->complex_count)) {
    | + update_queue(sma);
    | + } else {
    | + struct sem *sem;
    | +
    | + sem = &sma->sem_base[semnum];
    | + if (sem->semval > 0)
    | + update_negv_queue(sma, sem);
    | + if (sem->semval == 0)
    | + update_zero_queue(sma, sem);
    | + }
    | +}
    | +
    ...

    Hi Nick,

    mostly probably miss something but can't we trgigger BUG_ON at updating
    zero queue if semaphore was created with undo list and via new operation
    reached -ERANGE on undo value?

    Again, I could be missing something or plain wrong. Just a thought.

    -- Cyrill


    \
     
     \ /
      Last update: 2009-08-11 22:09    [W:2.418 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site