Messages in this thread | | | Date | Tue, 11 Aug 2009 14:52:58 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH] fix memory leak in virtio_net |
| |
(copying Rusty, the virtio maintainer)
On 08/10/2009 11:05 PM, Shirley Ma wrote: > Whild reading virtio code, I found some memory leak in removing > virtio_net. > > In virtnet_remove, only skb has been freed not the pages in skb > frags. Here is the patch to fix this, please review it. > >
There were indeed reports of virtio ooming; this might be the cause.
> Signed-off-by: Shirley Ma<xma@us.ibm.com> > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 2a6e81d..7e629d9 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -978,6 +978,7 @@ static void virtnet_remove(struct virtio_device *vdev) > > /* Free our skbs in send and recv queues, if any. */ > while ((skb = __skb_dequeue(&vi->recv)) != NULL) { > + trim_pages(vi, skb); > kfree_skb(skb); > vi->num--; > } > > > > >
-- error compiling committee.c: too many arguments to function
| |