Messages in this thread Patch in this message | | | Date | Tue, 11 Aug 2009 08:17:35 +0200 | From | Takashi Iwai <> | Subject | Re: linux-next: sound tree build warning |
| |
At Tue, 11 Aug 2009 13:22:58 +1000, Stephen Rothwell wrote: > > Hi Takashi, > > Today's linux-next build (x86_64 allmodconfig) produced this warning: > > sound/usb/usbaudio.c: In function 'init_substream_urbs': > sound/usb/usbaudio.c:1087: warning: comparison of distinct pointer types lacks a cast > > Introduced by commit 765e8db078e63fdc076fcf6024c15d3b7b955746 ("sound: > usb-audio: do not make URBs longer than sync packet interval").
Thanks, fixed now on sound git tree with the patch below.
Takashi
--- diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index fa3f7a1..5149c58 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -1084,7 +1084,7 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri urb_packs = 1; urb_packs *= packs_per_ms; if (subs->syncpipe) - urb_packs = min(urb_packs, 1 << subs->syncinterval); + urb_packs = min(urb_packs, 1U << subs->syncinterval); /* decide how many packets to be used */ if (is_playback) {
| |