Messages in this thread | | | Date | Mon, 10 Aug 2009 09:29:10 -0700 | From | Greg KH <> | Subject | Re: [patch 2/5] Staging: vme: add VME userspace driver |
| |
On Mon, Aug 10, 2009 at 05:26:06PM +0200, Emilio G. Cota wrote: > Martyn Welch wrote: > >>> Instead of using that we implemented a heretic IOCTL-based > >>> interface for user-space; at least with it you could create a > [ snip ] > >>> #define VME_IOCTL_START_DMA _IOWR('V', 10, struct vme_dma) > >>> > > I am moving the interface in that direction, I remain unconvinced about > > the contents of your vme_mapping structure, it's too tsi-148 specific. > > Could you please point out why is too tsi148-specific? > > The point here is that the driver should know *nothing* about > windows, etc. What it should just know is: > - I want a mapping of a certain size to VME address X > The struct provides exactly this.
So does the existing UIO interface, right? Please don't reinvent the wheel here :)
thanks,
greg k-h
| |