Messages in this thread |  | | | From | Bjorn Helgaas <> | | Subject | Re: [patch 2/2] Add a driver for the Winbond WPCD376I Consumer IR hardware | | Date | Mon, 10 Aug 2009 09:39:53 -0600 |
| |
On Sunday 09 August 2009 03:56:47 am david@hardeman.nu wrote: > --- linux-2.6.orig/drivers/input/misc/Kconfig 2009-07-25 21:18:57.000000000 +0200 > +++ linux-2.6/drivers/input/misc/Kconfig 2009-08-07 21:45:41.000000000 +0200 > @@ -222,6 +222,22 @@ > To compile this driver as a module, choose M here: the > module will be called sgi_btns. > > +config INPUT_WINBOND_CIR > + tristate "Winbond IR remote control" > + depends on X86 && ACPI
This should depend on PNP, not ACPI.
> +#define WBCIR_ACPI_NAME "Winbond CIR"
You might remove "ACPI" from "WBCIR_ACPI_NAME," since it has nothing to do with ACPI.
Otherwise, looks good to me.
Bjorn
|  |