lkml.org 
[lkml]   [2009]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void)
On 07/09, Christoph Hellwig wrote:
>
> On Thu, Jul 09, 2009 at 11:28:47PM +0200, Oleg Nesterov wrote:
> > (on top of rework-fix-is_single_threaded.patch)
> >
> > - is_single_threaded(task) is not safe unless task == current,
> > we can't use task->signal or task->mm.
> >
> > - it doesn't make sense unless task == current, the task can
> > fork right after the check.
> >
> > Rename it to is_current_single_threaded() and kill the argument.
>
> It would be more natural to put the current first, as in
> current_is_single_threaded(). That would also fit with the various
> other current_* helpers we have.

Agreed, re-sending.

Oleg.



\
 
 \ /
  Last update: 2009-07-10 03:53    [W:0.066 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site