lkml.org 
[lkml]   [2009]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/7] MAINTAINERS: Remove L:
From
Date
On Thu, 2009-07-09 at 10:30 +0100, Mark Brown wrote:
> FWIW I've noticed that get_maintainer.pl has a tendency to pick up
> people it probably shouldn't when run on areas that have had few people
> committing to them since it tends to pick up people who've done generic
> cleanups but have no specific interest in that area of code. I think a
> heuristic based on filtering the git log based on the proportion of
> commits that were done by each committer would help with many of these
> cases.

Hi Mark.

git log "-by:" lines are already sorted by number of commits
before selecting maintainers. It doesn't matter if the
line is acked-by:, Signed-off-by:, tested-by:, or
brown-paper-bagged-by:, any "by:" signature is used.

get_maintainers does:

git log --since=${email_git_since} -- ${file} \
| grep -Ei "^[-_ a-z]+by:.*\@.*$" \
| cut -f2- -d":" | sort | uniq -c | sort -rn
There are a few existing options that could be used
to minimize cleanup style committers.

--git => include recent git *-by: signers
--git-min-signatures => number of signatures required (default: 1)
--git-max-maintainers => maximum maintainers to add (default: 5)
--git-since => git history to use (default: 1-year-ago)

Using --nogit lists just the entries in MAINTAINERS

Using --git-min-signatures=3 or so seems to minimize
the generic cleanups committers.

Using --git-max-maintainers=3 or so, for files with more
changes, seems also to minimize the generic cleanup committers

Using --git-since=6-months-ago reduces the history period

Using --stat on the commit log and weighting for things
for lines changed would probably not be good because generic
cleanups often change more of the code than real logic
changes.

I suppose when the number of committers returned by
the "git log | grep" is low, returning just the
most frequent committers might be good.
Any suggestions on better heuristics?




\
 
 \ /
  Last update: 2009-07-09 17:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site