lkml.org 
[lkml]   [2009]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] block: implement mixed merge of different failfast requests
On 07/09/2009 03:47 AM, Tejun Heo wrote:
> Hello,
>
> Boaz Harrosh wrote:
>>> @@ -1165,6 +1165,7 @@ static int __make_request(struct request_queue *q, struct bio *bio)
>>> const unsigned short prio = bio_prio(bio);
>>> const int sync = bio_sync(bio);
>>> const int unplug = bio_unplug(bio);
>>> + const unsigned int ff = bio->bi_rw & REQ_FAILFAST_MASK;
>> Perhaps a bio_fail_fast(bio)
>> and also an blk_failfast(rq).
>
> Me not being a big fan of those simple accessors, I want to avoid
> adding those especially the use of bio ones are mostly confined to
> block layer proper.
>

OK but at least take care of blk_noretry_request(), at the minimum
kill it, and use req->cmd_flags & REQ_FAILFAST_MASK everywhere.

> Thanks.
>

Thanks
Boaz


\
 
 \ /
  Last update: 2009-07-09 11:19    [W:0.051 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site