lkml.org 
[lkml]   [2009]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: lib: Export generic atomic64_t functions
Roland Dreier writes:

> The generic atomic64_t implementation in lib/ did not export the
> functions it defined, which means that modules that use atomic64_t
> would not link on platforms (such as 32-bit powerpc). For example,
> trying to build a kernel with CONFIG_NET_RDS on such a platform would
> fail with:
>
> ERROR: "atomic64_read" [net/rds/rds.ko] undefined!
> ERROR: "atomic64_set" [net/rds/rds.ko] undefined!
>
> Fix this by exporting the atomic64_t functions to modules. (I export
> the entire API even if it's not all currently used by in-tree modules to
> avoid having to continue fixing this in dribs and drabs)
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Nice, thanks.

Acked-by: Paul Mackerras <paulus@samba.org>

Andrew, I think this should be safe to go in 2.6.31. Could you
include it in your next batch for Linus, or should I send it to him
directly?

Paul.


\
 
 \ /
  Last update: 2009-07-09 03:11    [W:0.074 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site