Messages in this thread | | | Date | Thu, 9 Jul 2009 11:09:24 +1000 | From | Paul Mackerras <> | Subject | Re: lib: Export generic atomic64_t functions |
| |
Roland Dreier writes:
> The generic atomic64_t implementation in lib/ did not export the > functions it defined, which means that modules that use atomic64_t > would not link on platforms (such as 32-bit powerpc). For example, > trying to build a kernel with CONFIG_NET_RDS on such a platform would > fail with: > > ERROR: "atomic64_read" [net/rds/rds.ko] undefined! > ERROR: "atomic64_set" [net/rds/rds.ko] undefined! > > Fix this by exporting the atomic64_t functions to modules. (I export > the entire API even if it's not all currently used by in-tree modules to > avoid having to continue fixing this in dribs and drabs) > > Signed-off-by: Roland Dreier <rolandd@cisco.com>
Nice, thanks.
Acked-by: Paul Mackerras <paulus@samba.org>
Andrew, I think this should be safe to go in 2.6.31. Could you include it in your next batch for Linus, or should I send it to him directly?
Paul.
| |