Messages in this thread |  | | | Date | Wed, 08 Jul 2009 09:19:14 +0900 | | From | Tejun Heo <> | | Subject | Re: [PATCH] vmalloc.c: fix double error checking |
| |
Figo.zhang wrote: > it is no need for double error checking. > > Signed-off-by: Figo.zhang <figo1802@gmail.com> > - err = vmap_pud_range(pgd, addr, next, prot, pages, &nr); > - if (err) > - break; > + if (vmap_pud_range(pgd, addr, next, prot, pages, &nr)) > + return -ENOMEM;
Wouldn't it be better to keep the error return value?
Thanks.
-- tejun
|  |