Messages in this thread | | | From | Robin Getz <> | Subject | Re: PREEMPT_ACTIVE too low error with all asm-generic headers for some arches | Date | Tue, 7 Jul 2009 08:41:14 -0400 |
| |
On Sat 4 Jul 2009 18:43, Mike Frysinger pondered: > On Wed, Jun 24, 2009 at 18:21, Mike Frysinger wrote: > > On Wed, Jun 24, 2009 at 11:02, Mike Frysinger wrote: > >> On Wed, Jun 24, 2009 at 10:02, Arnd Bergmann wrote: > >>> --- a/include/linux/hardirq.h > >>> +++ b/include/linux/hardirq.h > >>> @@ -62,6 +62,12 @@ > >>> #define HARDIRQ_OFFSET (1UL << HARDIRQ_SHIFT) > >>> #define NMI_OFFSET (1UL << NMI_SHIFT) > >>> > >>> +#ifndef PREEMPT_ACTIVE > >>> +#define PREEMPT_ACTIVE_BITS 1 > >>> +#define PREEMPT_ACTIVE_SHIFT (NMI_SHIFT + NMI_BITS) > >>> +#define PREEMPT_ACTIVE (__IRQ_MASK(PREEMPT_ACTIVE_BITS) << PREEMPT_SHIFT) > >> > >> i think you meant "<< PREEMPT_ACTIVE_SHIFT" there. once i make that > >> change, it builds fine. > > > > and like Ingo, with that fix, add my Acked-by > > > > thanks ! > > could you push this to Linus ? or should i throw something into the > Blackfin headers in the meantime ?
Yeah, this is causing build failures on Linux 2.6.31-rc2 for Blackfin.
In file included from include/linux/interrupt.h:12, from include/linux/kernel_stat.h:8, from arch/blackfin/kernel/asm-offsets.c:32: include/linux/hardirq.h:66:2: error: #error PREEMPT_ACTIVE is too low! make[1]: *** [arch/blackfin/kernel/asm-offsets.s] Error 1 make: *** [prepare0] Error 2
Which the above patch makes go away...
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |