Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 4/5] add isolate pages vmstat | Date | Mon, 6 Jul 2009 18:28:01 +0900 (JST) |
| |
> > ? ? ? ?printk("Active_anon:%lu active_file:%lu inactive_anon:%lu\n" > > - ? ? ? ? ? ? ? " inactive_file:%lu" > > - ? ? ? ? ? ? ? " unevictable:%lu" > > + ? ? ? ? ? ? ? " inactive_file:%lu unevictable:%lu isolated:%lu\n" > > It's good. > I have a one suggestion. > > I know this patch came from David's OOM problem a few days ago. > > I think total pages isolated of all lru doesn't help us much. > It just represents why [in]active[anon/file] is zero. > > How about adding isolate page number per each lru ? > > IsolatedPages(file) > IsolatedPages(anon) > > It can help knowing exact number of each lru.
Good suggestion! Will fix.
| |