Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 4/5] add isolate pages vmstat | Date | Tue, 7 Jul 2009 11:12:33 +0900 (JST) |
| |
> It looks good to me. > Thanks for your effort. I added my review sign. :) > > Let remain one side note. > This accounting feature results from direct reclaim bomb. > If we prevent direct reclaim bomb, I think this feature can be removed.
Hmmm. I disagree. isolated pages can become more than >1GB on server systems. Who want >1GB unaccountable memory?
> > As I know, Rik or Wu is making patch for throttling direct reclaim. > > On Tue, 7 Jul 2009 10:19:53 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > > > > Index: b/mm/vmscan.c > > > > > =================================================================== > > > > > --- a/mm/vmscan.c > > > > > +++ b/mm/vmscan.c > > > > > @@ -1082,6 +1082,7 @@ static unsigned long shrink_inactive_lis > > > > > -count[LRU_ACTIVE_ANON]); > > > > > __mod_zone_page_state(zone, NR_INACTIVE_ANON, > > > > > -count[LRU_INACTIVE_ANON]); > > > > > + __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, nr_taken); > > > > > > > > Lumpy can reclaim file + anon anywhere. > > > > How about using count[NR_LRU_LISTS]? > > > > > > Ah yes, good catch. > > > > Fixed. > > > > Subject: [PATCH] add isolate pages vmstat > > > > If the system have plenty threads or processes, concurrent reclaim can > > isolate very much pages. > > Unfortunately, current /proc/meminfo and OOM log can't show it. > > > > This patch provide the way of showing this information. > > > > > > reproduce way > > ----------------------- > > % ./hackbench 140 process 1000 > > => couse OOM > > > > Active_anon:146 active_file:41 inactive_anon:0 > > inactive_file:0 unevictable:0 > > isolated_anon:49245 isolated_file:113 > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > dirty:0 writeback:0 buffer:49 unstable:0 > > free:184 slab_reclaimable:276 slab_unreclaimable:5492 > > mapped:87 pagetables:28239 bounce:0 > > > > > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Reviewed-by: Minchan Kim <minchan.kim@gmail.com> > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
| |