Messages in this thread | | | From | Mike Frysinger <> | Date | Mon, 6 Jul 2009 16:23:31 -0400 | Subject | Re: [PATCH] Remove multiple KERN_ prefixes from printk formats |
| |
On Mon, Jul 6, 2009 at 16:05, Joe Perches wrote: > commit 5fd29d6ccbc98884569d6f3105aeca70858b3e0f changed > printk semantics. printk lines with multiple KERN_<level> > prefixes are no longer emitted as before the patch. > > <level> is now included in the output on each additional use. > > Remove all uses of multiple KERN_<level>s in formats.
thanks, i had started this in the Blackfin code a little, but your patch includes what i did and more, so the Blackfin stuff should be mostly fine (pending comments below).
> --- a/arch/blackfin/kernel/traps.c > +++ b/arch/blackfin/kernel/traps.c > @@ -212,7 +212,7 @@ asmlinkage void double_fault_c(struct pt_regs *fp) > console_verbose(); > oops_in_progress = 1; > #ifdef CONFIG_DEBUG_VERBOSE > - printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n"); > + printk(KERN_EMERG "Double Fault\n");
dropped a newline. we've largely made sure the newlines and such were as we want in the output ... in this case, it is not a matter of adding a newline where one did not exist before
> - verbose_printk(KERN_NOTICE "\n" KERN_NOTICE "Kernel Stack\n"); > + verbose_printk(KERN_NOTICE "Kernel Stack\n");
and here
> - verbose_printk(KERN_NOTICE "\n" KERN_NOTICE > - "No Valid process in current context\n"); > + verbose_printk(KERN_NOTICE > + "No Valid process in current context\n");
and here
> - verbose_printk(KERN_NOTICE "\n" KERN_NOTICE "SEQUENCER STATUS:\t\t%s\n", print_tainted()); > + verbose_printk(KERN_NOTICE "\nSEQUENCER STATUS:\t\t%s\n", > + print_tainted());
and here
> - verbose_printk(KERN_NOTICE "\n" KERN_NOTICE "PROCESSOR STATE:\n"); > + verbose_printk(KERN_NOTICE "PROCESSOR STATE:\n");
and here -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |