Messages in this thread |  | | | Date | Sun, 5 Jul 2009 15:23:35 +0200 | | From | Frederic Weisbecker <> | | Subject | Re: [PATCH 5/5] perf report: Support callchains with relative overhead rate |
| |
On Sun, Jul 05, 2009 at 10:59:49AM +0200, Ingo Molnar wrote: > > btw., i get some buggy looking output with: > > $ perf record -f -g ~/hackbench 10 > > $ perf report -c > > > |--5.11%-- unix_stream_sendmsg > | | > | |--100.00%-- __sock_sendmsg > | | sock_aio_write > | | do_sync_write > | | vfs_write > | | sys_write > | | sysenter_dispatch > | | 0xf7f72430 > | | 0xffebbca000000014 > | | > | --11.11%-- sock_aio_write > | do_sync_write > | vfs_write > | sys_write > | sysenter_dispatch > | 0xf7f72430 > | 0xffebbca000000014 > > Those percentages dont sum up to 100% :-)
Argh. I can reproduce it, will have a look.
> Another detail: i think we should signal when we crop the output due > to the filter, via a line of: > > | [...] > > or so.
Ok.
> Plus, when doing 'perf report' on a call-chain recording, shouldnt > we auto-detect this fact and default to fractal output > automatically, instead of flat mode? > > User can still force flat mode via 'perf report -c flat'.
Yeah but the user won't be able to ignore the callchain. May be I may add a -c none in this case?
|  |