Messages in this thread | | | Date | Sun, 5 Jul 2009 13:25:45 +0200 | From | Ingo Molnar <> | Subject | Re: [tip:perfcounters/urgent] x86: atomic64: Move the 32-bit atomic64_t implementation to a .c file |
| |
* Paul Mackerras <paulus@samba.org> wrote:
> tip-bot for Ingo Molnar writes: > > > Also, while at it, rename all uses of 'unsigned long long' to > > the much shorter u64. > > > > This makes the appearance of the prototypes a lot nicer - and > > it also uncovered a few bugs where (yet unused) API variants > > had 'long' as their return type instead of u64. > > Did you consider making atomic64_t a signed type on 32-bit x86 > like it is on all 64-bit platforms, and like atomic_t is > everywhere?
That did not occur to me and it makes sense - this would clean up a few explicit s64 casts we do there currently.
Ingo
| |