Messages in this thread |  | | | From | Arnd Bergmann <> | | Subject | Re: [PATCH 0/3] dma-mapping:remove CONFIG_HAVE_DMA_ATTRS | | Date | Sun, 5 Jul 2009 13:19:36 +0200 |
On Saturday 04 July 2009, tom.leiming@gmail.com wrote: > 2,Disabling CONFIG_HAVE_DMA_ATTRS may lead to a compile failure;
I'm not sure I understand this point. CONFIG_HAVE_DMA_ATTRS tells the common code whether the architecture understands dma attributes. If you enable it on all architectures, you will get new compile failures on all those that don't understand them, while the current code correctly falls back on the standard functions.
I think it makes sense to combine CONFIG_HAVE_DMA_ATTRS with the use of dma-mapping-common.h, but the majority of the architectures just uses a static mapping, where attributes make no sense.
You also missed powerpc64, which selects CONFIG_HAVE_DMA_ATTRS but does not (yet) use dma-mapping-common.h.
Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |