lkml.org 
[lkml]   [2009]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [KVM PATCH v9 0/5] irqfd fixes and enhancements
    On Sun, Jul 05, 2009 at 01:16:24PM +0300, Michael S. Tsirkin wrote:
    > On Sun, Jul 05, 2009 at 12:28:30PM +0300, Avi Kivity wrote:
    > > On 07/02/2009 06:50 PM, Avi Kivity wrote:
    > >> On 07/02/2009 06:37 PM, Gregory Haskins wrote:
    > >>> (Applies to kvm.git/master:1f9050fd)
    > >>>
    > >>> The following is the latest attempt to fix the races in
    > >>> irqfd/eventfd, as
    > >>> well as restore DEASSIGN support. For more details, please read the
    > >>> patch
    > >>> headers.
    > >>>
    > >>> As always, this series has been tested against the kvm-eventfd unit test
    > >>> and everything appears to be functioning properly. You can download this
    > >>> test here:
    > >>
    > >> Applied, thanks.
    > >>
    > >
    > > ... and unapplied. There's a refcounting mismatch in irqfd_cleanup: a
    > > reference is taken for each irqfd, but dropped for each guest. This
    > > causes an oops if a guest with no irqfds is created and destroyed:
    >
    > Ugh, apparently this logic has been changed between I acked v7 of the
    > patches and between Avi applied v9. Will have to find the time to redo
    > the review - or maybe just go back to v7? Is on-demand wq creation
    > really that important?

    Avi, is it true that just reverting the last patch in series,
    c9a2686e39e9095772ec6453f89c417a8e166f11, fixes the issue?

    --
    MST


    \
     
     \ /
      Last update: 2009-07-05 12:23    [W:0.024 / U:126.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site