Messages in this thread | | | Date | Sun, 5 Jul 2009 21:17:39 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [RFC -tip] x86,apic -- reduce disable_apic usage |
| |
[Cyrill Gorcunov - Sun, Jul 05, 2009 at 09:12:51PM +0400] | [Cyrill Gorcunov - Sun, Jul 05, 2009 at 08:59:47PM +0400] | | [Maciej W. Rozycki - Sun, Jul 05, 2009 at 05:38:52PM +0100] | | | On Sun, 5 Jul 2009, Cyrill Gorcunov wrote: | | | | | | > Here is an attempt to bring more consistency for apic | | | > presence check. I hope I covered all the code flows. | | | > Though it's RFC. Please review and test if possible. | | | > | | | > -- Cyrill | | | > --- | | | > Instead of messing with (cpu_has_apic|disable_apic) | | | > to check if we have apic functional, better to distinguish | | | > them by logical kind. cpu_has_apic -- to check if we may | | | > use apic functionality, disable_apic -- to note that | | | > apic was disabled via command line. | | | | | | How do you set cpu_has_apic for systems with discrete local APICs? The | | | CPUID flag is not set in this case. | | | | | | Maciej | | | -- | | | | | | | Well, indeed, somehow forgot about this case. Thanks Maciej! | | The patch should be dropped. | | | | -- Cyrill | | Hmm... But if we have no MP table parsed and no "lapic" option | passed we should leave execution in pure PIC mode. Or I miss | something? | | -- Cyrill
To be precise -- for discrete apic we set this bit manually.
-- Cyrill
| |