lkml.org 
[lkml]   [2009]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] io context: fix ref counting
    On Fri, Jul 31 2009, Li Zefan wrote:
    > Commit d9c7d394a8ebacb60097b192939ae9f15235225e
    > ("block: prevent possible io_context->refcount overflow") mistakenly
    > changed atomic_inc(&ioc->nr_tasks) to atomic_long_inc(&ioc->refcount).
    >
    > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    > ---
    > include/linux/iocontext.h | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/include/linux/iocontext.h b/include/linux/iocontext.h
    > index dd05434..4da4a75 100644
    > --- a/include/linux/iocontext.h
    > +++ b/include/linux/iocontext.h
    > @@ -92,7 +92,7 @@ static inline struct io_context *ioc_task_link(struct io_context *ioc)
    > * a race).
    > */
    > if (ioc && atomic_long_inc_not_zero(&ioc->refcount)) {
    > - atomic_long_inc(&ioc->refcount);
    > + atomic_inc(&ioc->nr_tasks);
    > return ioc;
    > }

    Irk, good catch. Applied to immediate upstream branch.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2009-07-31 08:57    [W:0.048 / U:0.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site