Messages in this thread |  | | | Date | Fri, 3 Jul 2009 19:29:47 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH] vt: add an event interface |
> + if( tty->count == 1 && port->count != 1) { > > and you pushed that piece of code upstream, and you called > checkpatch a religion - so apparently you were not using that tool > and apparently you think it's fine to push such changes upstream.
The discussion started about something else - a piece of non-compilable proposal code you space reviewed and didn't even notice wasn't compileable or sane.
I'm sort of amused you went back through my commits to find that example, and its certainly one that should have been fixed in the final submit. I can't be bothered to write a perl script to checkpatch all your commits and I suspect they all pass anyway.
I don't have a problem with that specific example you dug up being wrong. Its the "take a piece of non compileable initial sketch proposal, bitch about spaces and clearly not even look at the code itself" bit that bothers me.
If I'd have received "hey thats crap, your vt_waitactive conversion can't possibly work, and the console events are all off by one" I'd have understood it and agreed entirely (with or without the space note)
Alan
|  |