lkml.org 
[lkml]   [2009]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vt: add an event interface

* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Lennart how does this fit your needs - this replaces the existing wait
> active hack with a race free one and adds other events with a proper
> infrastructure for them.
>
> From: Alan Cox <alan@linux.intel.com>
>
> This is needed and requested in various forms for ConsoleKit, screenblank
> handling and the like so do the job with a single interface. Also build the
> interface so that unlike VT_WAITACTIVE and friends it won't miss events.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/char/vt.c | 4 +
> drivers/char/vt_ioctl.c | 181 ++++++++++++++++++++++++++++++++++-------------
> include/linux/vt.h | 14 ++++
> include/linux/vt_kern.h | 3 +
> kernel/power/console.c | 4 +
> 5 files changed, 152 insertions(+), 54 deletions(-)

Just a side-note, please run new patches through
scripts/checkpatch.pl:

total: 4 errors, 2 warnings, 0 checks, 294 lines checked

all four errors it flagged should be fixed.

Even the two warnings about over-long lines show real problem areas
that could be improved:

- the copy_from_user() in vt_event_wait_ioctl() could be shortened
if we didnt pass in an unsigned long (which is pointless anyway).
The cast to void __user * should be done in the ioctl
demultiplexer vt_ioctl(), and the ioctl ugliness should not
invade cleaner child functions such as vt_event_wait_ioctl().

- same for vt_event_wait_ioctl() - it passes in a type damaged by
ioctl's limitations. Such type limitations and ioctl demuxing
artifacts should be kept local to vt_ioctl().

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-07-03 08:47    [W:1.206 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site