Messages in this thread |  | | | Subject | Re: [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem | | From | Jaswinder Singh Rajput <> | | Date | Fri, 03 Jul 2009 15:40:45 +0530 |
| |
On Fri, 2009-07-03 at 11:30 +0200, Ingo Molnar wrote: > * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote: > > > > $ ./perf list shows vector events like : > > > > > > vec-adds OR add [Hardware vector event] > > > vec-muls OR multiply [Hardware vector event] > > > vec-divs OR divide [Hardware vector event] > > > vec-idle-cycles OR vec-empty-cycles [Hardware vector event] > > > vec-stall-cycles OR vec-busy-cycles [Hardware vector event] > > > vec-ops OR vec-operations [Hardware vector event] > > btw., why does this printout SHOUT the 'or'? It's certainly not an > important piece of information. Something like: > > vec-adds | add [Hardware vector event] > vec-muls | multiply [Hardware vector event] > vec-divs | divide [Hardware vector event] > vec-idle-cycles | vec-empty-cycles [Hardware vector event] > vec-stall-cycles | vec-busy-cycles [Hardware vector event] > vec-ops | vec-operations [Hardware vector event] > > looks better on all levels. >
'OR' is also used for other events. If this is the only issue, I request you to accept these 2 patches.
I will send incremental patch which will fix these 'OR's and also avoid duplicating of these functions.
Thanks, -- JSR
http://userweb.kernel.org/~jaswinder/
|  |