lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Bug in kernel 2.6.31, Slow wb_kupdate writeout
From
BTW, can you explain this code at the bottom of generic_sync_sb_inodes
for me?

if (wbc->nr_to_write <= 0) {
wbc->more_io = 1;
break;
}

I don't understand why we are setting more_io here? AFAICS, more_io
means there's more stuff to write ... I would think we'd set this if
nr_to_write was > 0 ?

Or just have the section below brought up above this
break check and do:

if (!list_empty(&sb->s_more_io) || !list_empty(&sb->s_io))
wbc->more_io = 1;

Am I just misunderstanding the intent of more_io ?


\
 
 \ /
  Last update: 2009-07-30 02:21    [W:0.129 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site