Messages in this thread | | | Date | Wed, 29 Jul 2009 17:19:34 -0700 | Subject | Re: Bug in kernel 2.6.31, Slow wb_kupdate writeout | From | Martin Bligh <> |
| |
BTW, can you explain this code at the bottom of generic_sync_sb_inodes for me?
if (wbc->nr_to_write <= 0) { wbc->more_io = 1; break; }
I don't understand why we are setting more_io here? AFAICS, more_io means there's more stuff to write ... I would think we'd set this if nr_to_write was > 0 ?
Or just have the section below brought up above this break check and do:
if (!list_empty(&sb->s_more_io) || !list_empty(&sb->s_io)) wbc->more_io = 1;
Am I just misunderstanding the intent of more_io ?
| |