lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] spi: Add support for device table matching
    On Wed, Jul 29, 2009 at 10:44:46PM +0100, Ben Dooks wrote:
    [...]
    > > + const struct spi_device_id *id_table;
    > > + int (*probe_id)(struct spi_device *spi,
    > > + const struct spi_device_id *id);
    >
    > how about leaving it at just probe and have either a call or a field
    > in the device that you can look at to see if this was a new style of
    > call?

    There are no technical difficulties with that, but it would be
    inconsitent wrt other "device table"-aware buses (i2c, pci, of).

    Note that I'm getting rid of probe_id function in patch 5/7, as a
    cleanup step. I want to keep "new features" and "api cleanups"
    separate. That way it's easier to review the changes.

    Thanks!

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2


    \
     
     \ /
      Last update: 2009-07-30 00:35    [W:0.039 / U:118.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site