lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 14/71] USB: EHCI: use the new clear_tt_buffer interface
On Tue, 28 Jul 2009, Greg KH wrote:

> 2.6.30-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Alan Stern <stern@rowland.harvard.edu>
>
> commit 914b701280a76f96890ad63eb0fa99bf204b961c upstream.
>
> This patch (as1256) changes ehci-hcd and all the other drivers in the
> EHCI family to make use of the new clear_tt_buffer callbacks. When a
> Clear-TT-Buffer request is in progress for a QH, the QH is not allowed
> to be linked into the async schedule until the request is finished.
> At that time, if there are any URBs queued for the QH, it is linked
> into the async schedule.

Greg, can we hold off on applying this patch to the stable tree?

It turns out that this change causes a WARN_ON to trigger in some
circumstances, and the proposed patch to fix _that_ hasn't yet been
submitted to the mainline because a few people have reported that it
leaks DMA pool memory. So far there hasn't been much progress in
tracking this down.

Alan Stern



\
 
 \ /
  Last update: 2009-07-29 15:59    [from the cache]
©2003-2011 Jasper Spaans