lkml.org 
[lkml]   [2009]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kdesu broken
    > IOW, the whole argument really hinges on the fact that calling 
    > flush_to_ldisc() manually (without any locking) is really not
    > fundamentally any different from the delayed work doing it from a timer.

    Which means the hangup path should be doing a cancel_delayed_work() in
    the case where its not resetting the termios as well and since it isn't
    you can't actually (fingers crossed) make the problem worse, its merely as
    broken as before.

    Ok

    > And when we _do_ disable the timer, we also make that flush_to_ldisc()
    > function be a no-op, so the "tty_ldisc_halt()" effectively stops both the
    > timer and (conceptually) the manual call case too.
    >
    > So now we have one remaining case, namely the case of the ldisc then being
    > re-initialized and TTY_LDISC is set again. But at that point, calling
    > flush_to_ldisc() had better be ok again, wouldn't you agree?

    The ldisc re-init via SETD should be fine as it locks versus hangup
    anyway and always has to.



    \
     
     \ /
      Last update: 2009-07-29 13:19    [W:0.021 / U:33.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site