lkml.org 
[lkml]   [2009]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 42/71] x86: geode: Mark mfgpt irq IRQF_TIMER to prevent resume failure
    2.6.30-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Thomas Gleixner <tglx@linutronix.de>

    commit d6c585a4342a2ff627a29f9aea77c5ed4cd76023 upstream.

    Timer interrupts are excluded from being disabled during suspend. The
    clock events code manages the disabling of clock events on its own
    because the timer interrupt needs to be functional before the resume
    code reenables the device interrupts.

    The mfgpt timer request its interrupt without setting the IRQF_TIMER
    flag so suspend_device_irqs() disables it as well which results in a
    fatal resume failure.

    Adding IRQF_TIMER to the interupt flags when requesting the mrgpt
    timer interrupt solves the problem.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <new-submission>
    Cc: Andres Salomon <dilinger@debian.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/mfgpt_32.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/mfgpt_32.c
    +++ b/arch/x86/kernel/mfgpt_32.c
    @@ -347,7 +347,7 @@ static irqreturn_t mfgpt_tick(int irq, v

    static struct irqaction mfgptirq = {
    .handler = mfgpt_tick,
    - .flags = IRQF_DISABLED | IRQF_NOBALANCING,
    + .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
    .name = "mfgpt-timer"
    };




    \
     
     \ /
      Last update: 2009-07-29 02:27    [W:3.232 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site