Messages in this thread | | | Date | Tue, 28 Jul 2009 18:16:13 -0600 | From | Alex Chiang <> | Subject | Re: [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled. |
| |
* Jesse Barnes <jesse.barnes@intel.com>: > On Fri, 24 Jul 2009 11:41:15 +0200 > Andi Kleen <andi@firstfloor.org> wrote: > > > Shut off pci_find_device warnings when the deprecated pci functions > > are enabled. > > > > Shut off the long standing > > > > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is > > deprecated (declared at linux/drivers/pci/search.c:136) > > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is > > deprecated (declared at linux/drivers/pci/search.c:136) > > > > warnings that appear on every build when CONFIG_PCI_LEGACY is enabled. > > > > gcc warns for the use in EXPORT_SYMBOL > > > > I moved these to a separate file and disabled the warning in the > > Makefile for that file. > > > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > > Applied to linux-next, thanks.
Maybe it's too late now, but I thought those warnings were supposed to motivate people to convert old, buggy drivers to get off the deprecated interface.
That's what finally motivated me to get rid of pci_find_slot() earlier...
By the way, this would also be a perfect kernelnewbies/kernel janitor cleanup, as it would require actually digging into drivers and making real, substantial changes as opposed to whitespace/checkpatch/typo patches.
Just a thought.
/ac
| |