lkml.org 
[lkml]   [2009]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch RFC 02/37] input: keyboard/hil_kbd: semaphore cleanup
On Sun, Jul 26, 2009 at 08:17:15AM -0000, Thomas Gleixner wrote:
> The usage of this "mutex" is non obvious and probably a completion in
> some places. Make it a semaphore.
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> ---
> drivers/input/keyboard/hil_kbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-tip/drivers/input/keyboard/hil_kbd.c
> ===================================================================
> --- linux-2.6-tip.orig/drivers/input/keyboard/hil_kbd.c
> +++ linux-2.6-tip/drivers/input/keyboard/hil_kbd.c
> @@ -277,7 +277,7 @@ static int hil_kbd_connect(struct serio
> serio_set_drvdata(serio, kbd);
> kbd->serio = serio;
>
> - init_MUTEX_LOCKED(&kbd->sem);
> + semaphore_init_locked(&kbd->sem);
>

I started working on conversion of that into a completion, I'll
commit as soon as I get someone to test it.

--
Dmitry


\
 
 \ /
  Last update: 2009-07-28 09:39    [from the cache]
©2003-2011 Jasper Spaans