[lkml]   [2009]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kdesu broken
Linus Torvalds <> writes:

>> n_tty_read() checks the pending buffer and consume it before
>> input_available_p().
> Why not move this _inside_ "input_available_p()"? There are only two
> call-sites, and strictly speaking they both want it.

The only reason for me is this is just quick hack.

Yes, I guess the input_available_p() is preferable place than my patch.
I'm still not checking the related path etc. deeply though.

OGAWA Hirofumi <>

 \ /
  Last update: 2009-07-28 18:19    [W:0.118 / U:0.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site