Messages in this thread |  | | | From | OGAWA Hirofumi <> | | Subject | Re: [PATCH] kdesu broken | | Date | Wed, 29 Jul 2009 01:16:51 +0900 |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes:
>> n_tty_read() checks the pending buffer and consume it before >> input_available_p(). > > Why not move this _inside_ "input_available_p()"? There are only two > call-sites, and strictly speaking they both want it.
The only reason for me is this is just quick hack.
Yes, I guess the input_available_p() is preferable place than my patch. I'm still not checking the related path etc. deeply though.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
|  |