lkml.org 
[lkml]   [2009]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net/bridge: use kobject_put to release kobject in br_add_if error path
From
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 24 Jul 2009 08:36:07 -0700

> On Fri, 24 Jul 2009 17:06:32 +0800
> Xiaotian Feng <dfeng@redhat.com> wrote:
>
>> kobject_init_and_add will alloc memory for kobj->name, so in br_add_if
>> error path, simply use kobject_del will not free memory for kobj->name.
>> Fix by using kobject_put instead, kobject_put will internally calls
>> kobject_del and frees memory for kobj->name.
>>
>> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
...
>
> I assume you tested this by doing something like adding two interfaces
> with the same MAC address to a bridge.
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks!


\
 
 \ /
  Last update: 2009-07-27 04:23    [W:0.076 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site