Messages in this thread Patch in this message |  | | | Date | Fri, 24 Jul 2009 22:10:26 -0400 | | From | Dave Jones <> | | Subject | [PATCH] Don't export scsi kernel variables in userspace headers. |
| |
Found with make headers_check
/usr/include/scsi/scsi.h:159: userspace cannot call function or variable defined in the kernel /usr/include/scsi/scsi.h:285: userspace cannot call function or variable defined in the kernel
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 084478e..689570e 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -156,7 +156,9 @@ scsi_varlen_cdb_length(const void *hdr) return ((struct scsi_varlen_cdb_hdr *)hdr)->additional_cdb_length + 8; } +#ifdef __KERNEL__ extern const unsigned char scsi_command_size_tbl[8]; +#endif #define COMMAND_SIZE(opcode) scsi_command_size_tbl[((opcode) >> 5) & 7] static inline unsigned @@ -281,8 +283,10 @@ enum scsi_protocol { SCSI_PROTOCOL_UNSPEC = 0xf, /* No specific protocol */ }; +#ifdef __KERNEL__ /* Returns a human-readable name for the device */ extern const char * scsi_device_type(unsigned type); +#endif /* * standard mode-select header prepended to all mode-select commands
|  |